Skip to content

Conversation

@gab-arrobo
Copy link
Contributor

In Kafka 24.0.0, autoCreateTopicsEnable was removed due to the implementation of readOnlyRootFs support. For the kafka.Reader to properly work with the latest version of the Helm Charts, the GroupID is removed

Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo gab-arrobo requested review from a team and Copilot September 17, 2025 05:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates Kafka configuration to be compatible with Kafka Helm Charts version 24.0.0 by removing the deprecated GroupID setting and making various code improvements.

  • Removes GroupID from Kafka reader configuration as it's no longer supported in Kafka 24.0.0
  • Updates logging format for better consistency and error handling
  • Refactors control flow structures and variable declarations for improved maintainability

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
metricfunc.go Moves configuration logging after IP address assignment for more accurate output
internal/reader/reader.go Removes deprecated GroupID, adds MaxBytes limit, and improves logging format consistency
internal/metricdata/subscriber.go Refactors if-else chain to switch statement and consolidates variable declaration
VERSION Updates version from 1.6.6-dev to 1.7.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo gab-arrobo merged commit a2c91f6 into omec-project:main Sep 17, 2025
9 checks passed
@gab-arrobo gab-arrobo deleted the update-kafka-settings branch September 17, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants