Address a few missing things from PR #445 and create a patch release#474
Merged
gab-arrobo merged 2 commits intoomec-project:mainfrom Mar 4, 2026
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
This PR finalizes a patch release by aligning the device-group API/schema documentation with the current model (including ip-domains and msisdns), refining QoS aggregation behavior, and bumping the project version from -dev to a release tag.
Changes:
- Update device-group schema/docs to use
ip-domains(array) and addmsisdns(array). - Enhance QoS aggregation to handle empty inputs, detect mixed bitrate units, and prefer higher-priority traffic classes.
- Set
VERSIONto2.1.1for the patch release.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
docs/docs.go |
Updates generated Swagger (v2) schema for device-groups (ip-domains, msisdns). |
configapi/slice_helpers.go |
Adds logic and logging around QoS aggregation (empty list handling, unit consistency, traffic class priority). |
configapi/api/configapi.yaml |
Updates OpenAPI (v3) schema for device-groups to match model (ip-domains, msisdns). |
VERSION |
Bumps version from 2.1.1-dev to 2.1.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
|
@gab-arrobo communicated that the E2E test is expected to fail pending a new release of simapp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.