Skip to content

Enforce Pydocstyle#152

Merged
AdrianDAlessandro merged 2 commits intomainfrom
pydocstyle
Mar 20, 2025
Merged

Enforce Pydocstyle#152
AdrianDAlessandro merged 2 commits intomainfrom
pydocstyle

Conversation

@AdrianDAlessandro
Copy link
Copy Markdown
Collaborator

Description

This PR enforces google style docstrings throughout the code for the ruff linter checks to pass.

I have needed to make my best-guess for describing what some of the functions and arguments are. Please confirm these make sense.

Fixes #130

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. pytest)
  • The documentation builds and looks OK (eg. mkdocs)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

Copy link
Copy Markdown
Collaborator

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice to see some extra type hints too.

There are some more numpy-style docstrings lurking (#139). Weird that ruff hasn't clocked them... Could tidy them up here or we can do it later.

@AdrianDAlessandro
Copy link
Copy Markdown
Collaborator Author

LGTM! Nice to see some extra type hints too.

There are some more numpy-style docstrings lurking (#139). Weird that ruff hasn't clocked them... Could tidy them up here or we can do it later.

Yea, I noticed that... I think since you already have another issue open for that, let's do it later.

@AdrianDAlessandro AdrianDAlessandro merged commit d5e05a0 into main Mar 20, 2025
10 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the pydocstyle branch March 20, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce pydocstyle in Ruff

2 participants