Skip to content

fix: fix non-determinism in pdf regression test #381

Merged
Thomas-Rowlands merged 7 commits intomainfrom
fix/fix-non-determinism-in-pdf-regression-test
Jan 13, 2026
Merged

fix: fix non-determinism in pdf regression test #381
Thomas-Rowlands merged 7 commits intomainfrom
fix/fix-non-determinism-in-pdf-regression-test

Conversation

@bp1183
Copy link
Collaborator

@bp1183 bp1183 commented Jan 12, 2026

Description

Added a fixed random seed to the test_pdf_to_bioc regression test which prevents inconsistencies in model output causing sporadic test failures.

Fixes #380

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • All tests pass (eg. pytest)
  • The documentation builds and looks OK (eg. mkdocs)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Thomas-Rowlands
Copy link
Collaborator

So I've spammed re-run on the tests for this PR many times now, not a single failure! LGTM!

@Thomas-Rowlands Thomas-Rowlands self-requested a review January 13, 2026 11:41
Copy link
Collaborator

@Thomas-Rowlands Thomas-Rowlands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-run the tests viciously and relentlessly, its holding up.

@Thomas-Rowlands Thomas-Rowlands merged commit b345eec into main Jan 13, 2026
52 checks passed
@Thomas-Rowlands Thomas-Rowlands deleted the fix/fix-non-determinism-in-pdf-regression-test branch January 13, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PDF regression tests show unreliable pass/fail rates.

2 participants