Regression test#48
Merged
Thomas-Rowlands merged 5 commits intoomicsNLP:mainfrom Oct 2, 2024
ImperialCollegeLondon:regression-test
Merged
Regression test#48Thomas-Rowlands merged 5 commits intoomicsNLP:mainfrom ImperialCollegeLondon:regression-test
Thomas-Rowlands merged 5 commits intoomicsNLP:mainfrom
ImperialCollegeLondon:regression-test
Conversation
Thomas-Rowlands
requested changes
Sep 30, 2024
Collaborator
Thomas-Rowlands
left a comment
Thomas-Rowlands
left a comment
There was a problem hiding this comment.
Added suggested changes to the test_regression.py file. Testing in Windows 11 throws an encoding error, which is resolved by specifying UTF-8. Looks good with this change however.
Collaborator
Author
|
@Thomas-Rowlands I've updated it to specify utf-8 encoding. Can you approve this PR to run workflows so that we can see if the test is passing? |
Thomas-Rowlands
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a regression test that can be run with
pytestThe data used for this test is the Open Access publication describing this software: https://doi.org/10.3389/fdgth.2022.788124 - it is Creative Commons licensed and the html used for the test includes the Creative Commons license text inside it, which automatically makes it comply with the license, as far as I can tell.