Skip to content

Update release.yml#95

Merged
Thomas-Rowlands merged 4 commits intomainfrom
Thomas-Rowlands-patch-1
Dec 20, 2024
Merged

Update release.yml#95
Thomas-Rowlands merged 4 commits intomainfrom
Thomas-Rowlands-patch-1

Conversation

@Thomas-Rowlands
Copy link
Copy Markdown
Collaborator

Fix for the publishing Github action.

Due to the nature of the action, this could need another change, but due to the error thrown this should get past the wheel building.

Fix for the publishing Github action.
Copy link
Copy Markdown
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, we made a small error here. You've identified the problem correctly, but the problem is related to not using the poetry virtual environment to get the package version.

There is also an additional issue that will not be solved by this PR. The tag used in the most recent release was v1.0.1, but the version in the pyproject.toml is 1.1.0, which means this workflow will fail anyway

Comment thread .github/workflows/release.yml
Updated to reflect Adrian's requested changes
Comment thread .github/workflows/release.yml Outdated
removed dependency installation step as per review comments.
@Thomas-Rowlands
Copy link
Copy Markdown
Collaborator Author

Edited the latest release to use the v1.1 tag to align with the pyproject.toml configuration, as I assume this was the intended release number. Combined with the changes made after review change requests, fingers crossed this sorts the problem out.

Copy link
Copy Markdown
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is all good to go!

The release tag will need to be changed to v1.1.0 so it is a valid semantic version string (all three numbers are always required). Also, the associated release action will need to be re-run if changing the release tag does not trigger a re-run

@Thomas-Rowlands Thomas-Rowlands merged commit 2fefd95 into main Dec 20, 2024
@AdrianDAlessandro
Copy link
Copy Markdown
Collaborator

@Thomas-Rowlands I have re-created Release v1.1.0 to trigger the workflow run. Unfortunately, I could not re-run the workflow because it was over 30 days old.

@Thomas-Rowlands Thomas-Rowlands deleted the Thomas-Rowlands-patch-1 branch February 10, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants