Add support for explicit use of selected low level kernel language constructs in @parallel_indices kernels
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One issue with the unit tests was found: |
omlins
commented
Dec 1, 2021
| @test_throws ArgumentError parallel_indices(:((ix,iy,iz)), :(f()=(99; return something))) # Error: function does not return nothing. | ||
| @test_throws ArgumentError parallel_indices(:((ix,iy,iz)), :(f()=(99; if x return y end; return))) # Error: function contains more than one return statement. | ||
| #TODO: this tests does not pass anymore for unknown reasons: | ||
| #@test_throws ArgumentError parallel_indices(:((ix,iy,iz)), :(f()=(99; if x return y end; return))) # Error: function contains more than one return statement. |
There was a problem hiding this comment.
This issue was reported here:
JuliaLang/julia#43289
luraess
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concretely, it adds support for:
│ Advanced
│
│ • @gridDim
│
│ • @blockIdx
│
│ • @Blockdim
│
│ • @threadIdx
│
│ • @sync_threads
│
│ • @sharedmem