feat: implement integration tests for keycloak token validation#50
Merged
empwilli merged 12 commits intoomnect:mainfrom Jul 28, 2025
Merged
feat: implement integration tests for keycloak token validation#50empwilli merged 12 commits intoomnect:mainfrom
empwilli merged 12 commits intoomnect:mainfrom
Conversation
The API had a hard dependency on the ODS and Keycloak. We tried to loosen these bounds by introducing dyn types, so that these dependencies could be tested more easily. However, there is no need to introduce this degree of flexibility. Instead, "normal" traits are sufficient (as the type of ODS provider/SSO provider won't change during the lifetime of the omnect-ui). This simplifies the code and avoids some of the cruft necessary to get mockall to work with the dyn traits. Additionally, this extracts the ODS and SSO provider creation, so that the creation of the API follows more closely dependency injection principles, thus simplifying testing even further.
empwilli
requested review from
JanZachmann and
ronny-standtke
and removed request for
JanZachmann
empwilli
changed the title
ronny-standtke
approved these changes
Jul 16, 2025
JanZachmann
reviewed
Jul 20, 2025
JanZachmann
reviewed
Jul 22, 2025
Contributor
Author
|
I've disabled unused code/imports warnings for mock builds in certificates.rs and omnect_device_service_client.rs. Please recheck. |
JanZachmann
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.