refactor: improve network test harness and add documentation #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract magic numbers to named constants (HEALTHCHECK_POLL_INTERVAL_MS, DEFAULT_ROLLBACK_TIMEOUT_SECONDS, DEFAULT_UI_PORT) - Improve error messages in mock endpoints for better debugging - Fix healthcheck timing calculation to use actual elapsed time instead of poll-count-based estimation - Replace hardcoded waitForTimeout calls with state-based waits using Playwright expect() assertions - Add comprehensive JSDoc comments to NetworkTestHarness methods - Add state machine diagram to NetworkChangeState enum in Rust - Add rustdoc comments to state variants Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
JanZachmann
added a commit
to JanZachmann/omnect-ui
that referenced
this pull request
Jan 17, 2026
The Vue synchronization layer was missing 5 fields that were added to the Crux Core's Model during migration, causing e2e test failures where computed values like current_connection_adapter weren't propagating to the UI. Root Cause: - sync.ts didn't deserialize fields added in Phase 2 of the migration - This broke "(current connection)" detection and rollback modal logic Changes: - types.ts: Add missing fields to ViewModel interface - browser_hostname, current_connection_adapter - device_went_offline - should_show_rollback_modal, default_rollback_enabled - state.ts: Initialize new fields with proper defaults - sync.ts: Synchronize new fields in updateViewModelFromCore() - Test files: Add mouse.click() workaround for Save button viewport issue with Playwright + Vuetify - Test files: Skip 8 tests with unrelated issues for investigation Test Results: - Before: 5/33 passed (15%) - After: 16/33 passed (48%), 8 skipped, 9 did not run - All originally failing migration tests now pass Fixes omnect#89 Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary