Metrics improvement #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lorenzoronzani
commented
Mar 29, 2024
lorenzoronzani
commented
- Refactor of small things based on those discussed during the meeting.
- Updated dashboards according to those used in the published version of grafana
ci 🚀: Saved the ic_ws_gw dashboards also in the local replica
ilbertt
requested changes
Mar 29, 2024
Member
ilbertt
left a comment
ilbertt
left a comment
There was a problem hiding this comment.
The PR looks good, well done!
I've left a few comments for some minor fixes. One is basically running:
cargo fmt
so that the files are formatted properly
ilbertt
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.