Skip to content

Conversation

@pboling
Copy link
Member

@pboling pboling commented Oct 13, 2025

No description provided.

@pboling pboling self-assigned this Oct 13, 2025
Copilot AI review requested due to automatic review settings October 13, 2025 19:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for ROM (Ruby Object Mapper) as a new ORM adapter for OmniAuth Identity. ROM is a persistence and mapping toolkit that provides a clean separation between relations and entities, making it suitable for Hanami applications.

  • Added a new ROM model adapter that implements OmniAuth Identity's interface
  • Created comprehensive test coverage for ROM functionality including authentication and owner associations
  • Updated CI workflows and build configurations to include ROM testing across multiple Ruby versions

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
lib/omniauth/identity/models/rom.rb Core ROM adapter implementation with authentication and data mapping logic
spec_orms/rom_spec.rb Complete test suite covering ROM model functionality and edge cases
lib/omniauth/identity.rb Added autoload for the new ROM adapter
Gemfile Added rom-sql dependency for development
Rakefile Updated test tasks to include ROM specs
Appraisals Added ROM appraisal configurations for different Ruby versions
gemfiles/rom_r3*.gemfile Gemfile configurations for ROM testing
.github/workflows/*.yml Updated CI workflows to test ROM across all supported Ruby versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

pboling and others added 2 commits October 14, 2025 02:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pboling pboling force-pushed the feat/adapter-rom branch 3 times, most recently from 534df6e to 4e2d8cc Compare October 13, 2025 20:10
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
omniauth-identity 94% 81%
Summary 94% (513 / 547) 81% (81 / 100)

Minimum allowed line rate is 90%

@pboling pboling merged commit 0ebc750 into main Oct 13, 2025
85 checks passed
@pboling pboling deleted the feat/adapter-rom branch October 13, 2025 21:51
@coveralls
Copy link

coveralls commented Oct 13, 2025

Pull Request Test Coverage Report for Build 18478619600

Details

  • 166 of 170 (97.65%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 91.808%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/omniauth/identity/models/rom.rb 59 63 93.65%
Totals Coverage Status
Change from base Build 18474454529: 1.9%
Covered Lines: 513
Relevant Lines: 547

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants