-
-
Couldn't load subscription status.
- Fork 100
✨ Hanami & ROM support #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for ROM (Ruby Object Mapper) as a new ORM adapter for OmniAuth Identity. ROM is a persistence and mapping toolkit that provides a clean separation between relations and entities, making it suitable for Hanami applications.
- Added a new ROM model adapter that implements OmniAuth Identity's interface
- Created comprehensive test coverage for ROM functionality including authentication and owner associations
- Updated CI workflows and build configurations to include ROM testing across multiple Ruby versions
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/omniauth/identity/models/rom.rb | Core ROM adapter implementation with authentication and data mapping logic |
| spec_orms/rom_spec.rb | Complete test suite covering ROM model functionality and edge cases |
| lib/omniauth/identity.rb | Added autoload for the new ROM adapter |
| Gemfile | Added rom-sql dependency for development |
| Rakefile | Updated test tasks to include ROM specs |
| Appraisals | Added ROM appraisal configurations for different Ruby versions |
| gemfiles/rom_r3*.gemfile | Gemfile configurations for ROM testing |
| .github/workflows/*.yml | Updated CI workflows to test ROM across all supported Ruby versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
534df6e to
4e2d8cc
Compare
4e2d8cc to
94b6cec
Compare
Pull Request Test Coverage Report for Build 18478619600Details
💛 - Coveralls |
No description provided.