-
-
Notifications
You must be signed in to change notification settings - Fork 158
✅ auth.uid as dn #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ auth.uid as dn #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation and test coverage to clarify the distinction between the LDAP search attribute (:uid config option) and the OmniAuth auth hash's auth.uid field, which always returns the Distinguished Name (DN).
- Adds a new test case demonstrating that
auth.uidreturns the DN (not thesAMAccountNameattribute value) when usingsAMAccountNameas the search attribute - Adds comprehensive README documentation explaining the difference between
:uidconfig option andauth.uidresult - Documents where to find username-style values (
auth.info.nicknameorauth.extra.raw_info)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spec/omniauth/strategies/ldap_spec.rb | Adds test case verifying that auth.uid returns DN when using sAMAccountName as the search attribute, and that nickname correctly maps from sAMAccountName |
| README.md | Adds new documentation section explaining the distinction between :uid config option (search attribute) and auth.uid result (DN), with examples and RFC references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fcf4f64 to
a97b52d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 4 4
Lines 219 219
Branches 59 59
=======================================
Hits 214 214
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a97b52d to
0eef3ad
Compare
0eef3ad to
25968b2
Compare
Documents and closes #50