Skip to content

Conversation

@pboling
Copy link
Member

@pboling pboling commented Nov 5, 2025

Documents and closes #84

@pboling pboling self-assigned this Nov 5, 2025
Copilot AI review requested due to automatic review settings November 5, 2025 11:16
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.54%. Comparing base (1170a30) to head (1c69dc4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files           4        4           
  Lines         244      244           
  Branches       67       67           
=======================================
  Hits          238      238           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances LDAP filter functionality by adding support for complex group-based filters with username placeholder substitution, escaping, and name_proc processing. The changes include comprehensive test coverage for these features and extensive documentation updates.

  • Replaced leaky constant declaration with proper stub_const usage in tests
  • Added test coverage for filter username escaping, name_proc application, and complex group filters
  • Added detailed documentation explaining filter behavior, escaping, and group-based authentication recipes

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
spec/omniauth/strategies/ldap_spec.rb Fixes RuboCop violation by using stub_const instead of class declaration; adds tests for filter escaping, name_proc application, and complex group filters in both password and header SSO flows
README.md Adds comprehensive documentation on filter behavior, escaping rules, group-based authentication recipes, and username normalization examples; fixes quotes in SASL section
.rubocop_gradual.lock Updates RuboCop gradual lock file to reflect resolution of LeakyConstantDeclaration violation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pboling pboling force-pushed the feat/document-filter branch from 8fbe3d8 to 1c69dc4 Compare November 5, 2025 11:23
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Code Coverage

Package Line Rate Branch Rate Health
omniauth-ldap 98% 82%
Summary 98% (228 / 233) 82% (62 / 76)

Minimum allowed line rate is 97%

@pboling pboling merged commit 0d369da into main Nov 5, 2025
30 of 31 checks passed
@pboling pboling deleted the feat/document-filter branch November 5, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unclear usage of the :filter argument

2 participants