feat: unify shell mode into agent subcommand#31
Merged
Conversation
Remove bare positional prompt from Cli struct. Shell mode is now accessed via `omni shell "prompt"` (alias: `omni sh`). This frees the argument space for plugin external_subcommand routing, so `omni run up runa` works without quoting. BREAKING CHANGE: `omni "list files"` is now `omni shell "list files"`
🦋 Changeset detectedLatest commit: b94fb08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
coopbri
changed the title
Local dev uses gitignored .cargo/config.toml paths override instead
coopbri
changed the title
Remove the standalone `omni shell` / `omni sh` subcommand. Natural language shell tasks are now handled by `omni agent`, aligning with the industry-standard single agentic entry point pattern.
The agent's built-in tool system handles shell execution via agent-core's ShellTool, making this standalone NL-to-command pipeline redundant.
coopbri
force-pushed
the
fix/remove-bare-prompt-positional
branch
from
d06ea4e to
b94fb08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the standalone
omni shellsubcommand in favor of a unified agent interface. Natural language shell tasks are now handled byomni agent, which routes simple shell commands through its existing tool system.This aligns with industry best practice (single agentic entry point) and reduces user-facing complexity.
omni agent "list files"(oromni a "list files")omni shell "list files"/omni sh "list files"(no longer works)omni "list files"(removed in prior commit)Also includes rustfmt formatting pass and removal of the committed
agent-corepatch override.Breaking change:
omni shell "prompt"is nowomni agent "prompt"Test Steps
cargo test cli::tests(19 tests pass)cargo build --release./target/release/omni agent "list files in current dir"works./target/release/omni a "list files"works (alias)./target/release/omni(no args launches TUI, unchanged)