fix: do not append start and goal if perfect match path found#966
Draft
HiroIshida wants to merge 3 commits intoompl:mainfrom
Draft
fix: do not append start and goal if perfect match path found#966HiroIshida wants to merge 3 commits intoompl:mainfrom
HiroIshida wants to merge 3 commits intoompl:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In lightning, if perfect match solution found, actually there is no need to append start and goal state.
To avoid adding duplicating start and goal states, adding conditioning depending on where the score is zero (perfect match) or not.
This PR fix this bug.
TODO:
This PR is complete as the current state, but I'd like to add test for this,(draft now)if test: add test for experience based planner #962 could be marged.