Skip to content

Release Source: GitHub Tags#9

Merged
ethanholz merged 18 commits intoomsf:mainfrom
dwhswenson:github-release
Apr 10, 2025
Merged

Release Source: GitHub Tags#9
ethanholz merged 18 commits intoomsf:mainfrom
dwhswenson:github-release

Conversation

@dwhswenson
Copy link
Copy Markdown
Member

@dwhswenson dwhswenson commented Apr 9, 2025

This also includes a translation that maps names of known packages to repos (e.g., "python" becomes "python/cpython").

TODO:

  • Add this into the main CLI; if the package looks like a repo name or is in the list of known repos, we default to using GitHub
  • Testing should probably include (optionally?) smoke tests on all known names

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 99.63899% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.29%. Comparing base (c267b53) to head (fa1a7bd).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/spec0/releasesource.py 98.79% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   99.18%   99.29%   +0.10%     
==========================================
  Files          15       15              
  Lines         616      853     +237     
==========================================
+ Hits          611      847     +236     
- Misses          5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dwhswenson dwhswenson requested a review from Copilot April 10, 2025 00:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • MANIFEST.in: Language not supported
  • src/spec0/data/github-releases.json: Language not supported
Comments suppressed due to low confidence (1)

src/spec0/releasesource.py:115

  • [nitpick] Consider using package.count('/') == 1 for checking the 'owner/repo' format, which is more efficient and clear.
if collections.Counter(package).get("/") == 1:

Comment thread src/spec0/releasesource.py Outdated
dwhswenson and others added 2 commits April 9, 2025 19:10
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dwhswenson dwhswenson requested a review from ethanholz April 10, 2025 00:13
Copy link
Copy Markdown
Contributor

@ethanholz ethanholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@ethanholz ethanholz merged commit 604af81 into omsf:main Apr 10, 2025
5 checks passed
@dwhswenson dwhswenson deleted the github-release branch April 10, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants