Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
On this one, you just need to correct the commit message, which contains a capital letter. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the accessibility of the homepage/customerpage switch by addressing an aria-required-children issue identified in Lighthouse audits.
- Removed Link wrappers in favor of a router-based tab navigation handler.
- Introduced explicit ARIA attributes (id and aria-controls) for both tab triggers and content panels to enhance accessibility.
Comments suppressed due to low confidence (1)
src/components/marketing/landing/page-switcher/index.tsx:36
- Using an empty string as the visitor tab value could lead to ambiguity in the overall tab design. Consider using a more explicit identifier like "visitor" to improve clarity.
<TabsTrigger value="" id="tab-trigger-visitor" aria-controls="tab-content-visitor">
| <div className="w-full fixed bottom-6 select-none"> | ||
| <Tabs | ||
| defaultValue="" | ||
| value={pathname.replace("/", "")} |
There was a problem hiding this comment.
Using pathname.replace("/", "") to derive the tab value can be brittle if more complex routing patterns are introduced in the future. Consider using a mapping function or explicit values for greater clarity and maintainability.
Suggested change
| value={pathname.replace("/", "")} | |
| value={getTabValue(pathname)} |
…om/onRuntime/onruntime-website into jcailly/fix-aria-required-children
…om/onRuntime/onruntime-website into jcailly/fix-aria-required-children
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modification fix aria-required-children issue in Lighthouse accessibility audit for the homepage/customerpage switch