-
-
Notifications
You must be signed in to change notification settings - Fork 0
🚚 move from yarn to pnpm #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughSwitches the repository from Yarn to pnpm (packageManager, CI, scripts), removes ESLint config and lint scripts, updates Next.js to v16 and MDX deps, drops i18n and experimental turbo config, adds a dev-types import, minor tsconfig changes, and replaces an img with Next.js Image in one page. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the project's package manager from yarn to pnpm, updating all related configuration files and documentation to reflect this change.
- Updates the package manager specification to pnpm 9.15.4
- Migrates CI/CD workflow to use pnpm commands and setup
- Cleans up yarn-specific configuration from .gitignore
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates packageManager field from yarn 1.22.22 to pnpm 9.15.4 |
| README.md | Simplifies getting started instructions to show only pnpm dev command |
| .gitignore | Removes yarn-specific entries (PnP, .yarn directory, yarn debug logs) |
| .github/workflows/checks.yml | Replaces yarn commands with pnpm equivalents and updates setup action |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (4)
.github/workflows/checks.yml.gitignoreREADME.mdpackage.json
💤 Files with no reviewable changes (2)
- README.md
- .gitignore
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Upload results
🔇 Additional comments (3)
.github/workflows/checks.yml (3)
25-25: LGTM! Cache configuration updated correctly.The cache is properly configured for PNPM, which will cache
~/.pnpm-storeto speed up dependency installation.
27-34: LGTM! All commands migrated correctly.All package manager commands have been properly updated from Yarn to PNPM:
yarn install→pnpm installyarn lint→pnpm lintyarn build→pnpm build
18-19: Configuration is correct and follows best practices.The
pnpm/action-setup@v4action correctly reads thepackageManagerfield frompackage.jsonand will install PNPM 9.15.4 as specified. Version 4 is the latest major version (currently at v4.2.0), so the configuration will receive latest improvements and security updates automatically.
📝 Changed routes:
Commit dfff68b (https://onruntime-website-d9bu3ymia-onruntime.vercel.app). |
![Screenshot of /agency/[city]](https://images.weserv.nl?url=https://sjc.microlink.io/5eI1u2tLi4-dZkdRaYV7d7T70biXjf8hL6j_Sh4wTYqi1ci7mddOAsGWlwi3wOf63SkExsxBKEUXKb8dP5t0Ig.png&w=600)
Summary by CodeRabbit
Chores
Documentation
Bug Fixes / UX
✏️ Tip: You can customize this high-level summary in your review settings.