Skip to content

Conversation

@antoinekm
Copy link
Member

@antoinekm antoinekm commented Dec 27, 2025

Summary by CodeRabbit

  • Chores

    • Switched project and CI to pnpm as the package manager; updated project dependencies (including Next.js and MDX).
    • Removed linting tooling and related scripts.
  • Documentation

    • Removed the example development-start commands from the README.
  • Bug Fixes / UX

    • Testimonial avatars now use optimized image handling.
    • Removed site i18n settings for the French locale (locale no longer active).

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings December 27, 2025 23:34
@vercel
Copy link

vercel bot commented Dec 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
onruntime-website Ready Ready Preview, Comment Dec 27, 2025 11:51pm

@coderabbitai
Copy link

coderabbitai bot commented Dec 27, 2025

Caution

Review failed

The pull request is closed.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Switches the repository from Yarn to pnpm (packageManager, CI, scripts), removes ESLint config and lint scripts, updates Next.js to v16 and MDX deps, drops i18n and experimental turbo config, adds a dev-types import, minor tsconfig changes, and replaces an img with Next.js Image in one page.

Changes

Cohort / File(s) Summary
CI workflow
\.github/workflows/checks.yml
Replaces Corepack/Yarn setup with pnpm/action-setup, switches Node cache and dependency commands to pnpm, renames workflow and removes the lint step.
Package manifest & deps
package.json
Changes packageManager to pnpm@10.26.2+..., upgrades next to 16.1.1, @next/mdx to ^16.1.1, re-adds next-mdx-remote@^5.0.0, and removes ESLint-related devDependencies; lint scripts removed.
Repo config & docs
\.gitignore, README.md, eslint.config.mjs
Removes Yarn/.pnp ignore patterns from .gitignore; README dev-server code block lines removed; eslint.config.mjs deleted (ESLint config removed).
Next.js config & types
next.config.mjs, next-env.d.ts, tsconfig.json
Removes i18n and experimental.turbo entries from next.config.mjs; adds import for ./.next/dev/types/routes.d.ts in next-env.d.ts; updates JSX runtime and include/exclude entries in tsconfig.json (formatting and added dev types).
App change
src/app/agency/[city]/page.tsx
Replaces a plain <img> with Next.js Image component for testimonial avatars and adds the next/image import with width/height attributes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 Hop, I dug through package trees tonight,

swapped yarn for pnpm with nimble light,
lint rules gone and configs trimmed,
Next got brighter, types newly primed —
a little hop, dependencies take flight!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: migrating from Yarn to PNPM package manager across the project.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55feb35 and dfff68b.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • .github/workflows/checks.yml
  • eslint.config.mjs
  • next-env.d.ts
  • next.config.mjs
  • package.json
  • src/app/agency/[city]/page.tsx
  • tsconfig.json

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the project's package manager from yarn to pnpm, updating all related configuration files and documentation to reflect this change.

  • Updates the package manager specification to pnpm 9.15.4
  • Migrates CI/CD workflow to use pnpm commands and setup
  • Cleans up yarn-specific configuration from .gitignore

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

File Description
package.json Updates packageManager field from yarn 1.22.22 to pnpm 9.15.4
README.md Simplifies getting started instructions to show only pnpm dev command
.gitignore Removes yarn-specific entries (PnP, .yarn directory, yarn debug logs)
.github/workflows/checks.yml Replaces yarn commands with pnpm equivalents and updates setup action

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@antoinekm antoinekm changed the title 🚚 move from yarn to pnpm @coderabbitai 🚚 move from yarn to pnpm Dec 27, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60acba3 and 55feb35.

⛔ Files ignored due to path filters (2)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • .github/workflows/checks.yml
  • .gitignore
  • README.md
  • package.json
💤 Files with no reviewable changes (2)
  • README.md
  • .gitignore
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Upload results
🔇 Additional comments (3)
.github/workflows/checks.yml (3)

25-25: LGTM! Cache configuration updated correctly.

The cache is properly configured for PNPM, which will cache ~/.pnpm-store to speed up dependency installation.


27-34: LGTM! All commands migrated correctly.

All package manager commands have been properly updated from Yarn to PNPM:

  • yarn installpnpm install
  • yarn lintpnpm lint
  • yarn buildpnpm build

18-19: Configuration is correct and follows best practices.

The pnpm/action-setup@v4 action correctly reads the packageManager field from package.json and will install PNPM 9.15.4 as specified. Version 4 is the latest major version (currently at v4.2.0), so the configuration will receive latest improvements and security updates automatically.

@antoinekm
Copy link
Member Author

antoinekm commented Dec 27, 2025

@antoinekm antoinekm merged commit 0113154 into master Dec 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants