Skip to content

Conversation

@Schanze97
Copy link
Collaborator

@Schanze97 Schanze97 commented Jan 22, 2026

#83

  • added validation rule interface for TitledSetting. The first version only shows validation warnings/errors for the CheckBoxSetting.
  • added AdvancedComboBoxSearchSetting
  • added OnSaved event in ISettingsService

Note for validation logic: When throwing an exception inside the validator class, it is possible to intentionally prevent assigning invalid values to the bound property. This causes the behavior, if the view/vm is not in sync, that setting the previous value won't cause the setter to get executed. In this case the validation text was not updated. To solve this problem I added the InvalidateValidation command to the Checkbox. The drawback is, that the rule will be always execute twice. When extending this feature, other controls need to implement a similar behavior as well. Using the more standard way with INotifyDataErrorInfo is not simply possible due to architectural reasons.

@hendrikmennen hendrikmennen merged commit a625134 into main Jan 25, 2026
1 check passed
@hendrikmennen hendrikmennen deleted the feature/#83-setting-validation branch January 25, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants