[HCR-425] Hotfix/hsc 425#287
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 관리자 통계 기능을 위한 캐싱 인프라 구축과 AdminRegionalTopPlanDao의 쿼리 성능 개선을 포함하고 있습니다. Caffeine 캐시를 도입하여 지역별 지표 및 요금제 데이터를 캐싱하도록 설정하였으며, jOOQ 쿼리를 리팩토링하여 중복 제거 및 카운트 로직을 최적화했습니다. 다만, 새로운 설정 클래스의 등록 방식이 프로젝트 스타일 가이드를 위반하고 있으며, 불필요한 코드와 표준 라이브러리 미사용, 그리고 데이터 타입 불일치 문제가 발견되어 수정이 필요합니다.
🧪 Test Coverage Report (JaCoCo)
Package line spark (sample): 📦 Package coverage (worst 10)
🧨 Lowest coverage classes (worst 10)
🧩 Changed files coverage breakdown (5 files)
🔎 HTML 리포트: Actions → Artifacts → |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝작업 내용
관리자 통계 api 속도를 줄이기 위한 쿼리튜닝, 인덱스, 캐시 처리
👀변경 사항
build.gradlespring-boot-starter-cache,caffeine의존성 추가HolliverseApplication.java@EnableCaching추가application.yamlregional-metrics,regional-top-plans캐시 spec 설정 추가CacheConfig.java캐시 이름 상수 정의
CompositeCacheManager구현RetrieveRegionalMetricUseCase.java@Cacheable(..., key = "#requestDto.yyyymm()", sync = true)적용RetrieveRegionalTopPlanUseCase.java@Cacheable(..., sync = true)적용AdminRegionalTopPlanDao.javadistinct → count(*) → row_number()구조로 재작성🎫 Jira Ticket
#️⃣관련 이슈