[SYCLomatic] Update the error handling of user-defined rule#122
Merged
zhimingwang36 merged 3 commits intooneapi-src:SYCLomaticfrom Jul 18, 2022
Merged
[SYCLomatic] Update the error handling of user-defined rule#122zhimingwang36 merged 3 commits intooneapi-src:SYCLomaticfrom
zhimingwang36 merged 3 commits intooneapi-src:SYCLomaticfrom
Conversation
Signed-off-by: Huang, Andy <andy.huang@intel.com>
Signed-off-by: Huang, Andy <andy.huang@intel.com>
AndyCHHuang
commented
Jul 15, 2022
| llvm::errs() << RuleFile << ":Error: in rule " << RuleName | ||
| << ", expect a positive integer, found " << ArgIndex | ||
| << " after " << Keyword << "\n"; | ||
| } else { |
Contributor
Author
There was a problem hiding this comment.
could remove if stmt if assigned keyword to "$" in function call
Signed-off-by: Huang, Andy <andy.huang@intel.com>
zhiweij1
approved these changes
Jul 18, 2022
Contributor
|
The BLAS-related failures are expected. One will be fixed in a SYCLomatic PR. Another bug is in MKL. |
ShengchenJ
pushed a commit
to ShengchenJ/SYCLomatic
that referenced
this pull request
Sep 27, 2024
…reference type (oneapi-src#122) Signed-off-by: Cai, Justin <justin.cai@intel.com>
ShengchenJ
pushed a commit
to ShengchenJ/SYCLomatic
that referenced
this pull request
Sep 27, 2024
…:device_reference type (oneapi-src#122)" (oneapi-src#134) This reverts commit a411e25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Huang, Andy andy.huang@intel.com