[SYCLomatic] Use oneDPL provided sort_by_key #1996
Merged
zhimingwang36 merged 11 commits intoSYCLomaticfrom Sep 5, 2024
Merged
[SYCLomatic] Use oneDPL provided sort_by_key #1996zhimingwang36 merged 11 commits intoSYCLomaticfrom
zhimingwang36 merged 11 commits intoSYCLomaticfrom
Conversation
danhoeflinger
changed the title
danhoeflinger
force-pushed
the
dev/dhoeflin/sort_by_key_improvement
branch
from
81c1a8d to
318a956
Compare
Contributor
Author
|
It seems there is an issue with same mangled name for a kernel. I will see if it is something with the test, or with oneDPL... |
danhoeflinger
force-pushed
the
dev/dhoeflin/sort_by_key_improvement
branch
from
80f3bbf to
e2e5aa7
Compare
danhoeflinger
force-pushed
the
dev/dhoeflin/sort_by_key_improvement
branch
from
e2e5aa7 to
83ebd80
Compare
danhoeflinger
force-pushed
the
dev/dhoeflin/sort_by_key_improvement
branch
2 times, most recently
from
05f2f07 to
0ed48a8
Compare
the-slow-one
approved these changes
Aug 21, 2024
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
…eDPL Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger
force-pushed
the
dev/dhoeflin/sort_by_key_improvement
branch
from
0ed48a8 to
aaa498a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oneDPL has added a
sort_by_keyAPI, so its best to use that when we can. This enables optimizations like radix sort for key types which allow it.