Skip to content

[SYCLomatic] Add support for cuCtxEnablePeerAccess #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhimingwang36 merged 11 commits into from
Jun 27, 2024
Merged

[SYCLomatic] Add support for cuCtxEnablePeerAccess #2055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eeaa244
Add support for cuCtxEnablePeerAccess
Jun 12, 2024
32f6605
Merge branch 'SYCLomatic' into 6275_cuCtxEnablePeerAccess
Jun 12, 2024
548da83
Format code
Jun 12, 2024
53d56fb
Use template CALL for MEMBER_CALL
Jun 12, 2024
c97980b
Merge branch '6275_cuCtxEnablePeerAccess' of https://github.com/the-s…
Jun 12, 2024
46b657c
Merge branch 'oneapi-src:SYCLomatic' into 6275_cuCtxEnablePeerAccess
Jun 18, 2024
28a477a
Merge branch 'oneapi-src:SYCLomatic' into 6275_cuCtxEnablePeerAccess
Jun 18, 2024
91cc685
Merge branch 'oneapi-src:SYCLomatic' into 6275_cuCtxEnablePeerAccess
Jun 20, 2024
fe1c8d2
Merge branch 'oneapi-src:SYCLomatic' into 6275_cuCtxEnablePeerAccess
Jun 20, 2024
05ee5a2
Merge branch 'oneapi-src:SYCLomatic' into 6275_cuCtxEnablePeerAccess
Jun 24, 2024
9ae6a07
Merge branch 'oneapi-src:SYCLomatic' into 6275_cuCtxEnablePeerAccess
Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/DPCT/APINames.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1708,7 +1708,7 @@ ENTRY(cuOccupancyMaxActiveBlocksPerMultiprocessorWithFlags, cuOccupancyMaxActive
ENTRY(cuOccupancyMaxPotentialBlockSize, cuOccupancyMaxPotentialBlockSize, false, NO_FLAG, P4, "comment")
ENTRY(cuOccupancyMaxPotentialBlockSizeWithFlags, cuOccupancyMaxPotentialBlockSizeWithFlags, false, NO_FLAG, P4, "comment")
ENTRY(cuCtxDisablePeerAccess, cuCtxDisablePeerAccess, false, NO_FLAG, P4, "comment")
ENTRY(cuCtxEnablePeerAccess, cuCtxEnablePeerAccess, false, NO_FLAG, P4, "comment")
ENTRY(cuCtxEnablePeerAccess, cuCtxEnablePeerAccess, true, NO_FLAG, P0, "DPCT1026/DPCT1027")
ENTRY(cuDeviceCanAccessPeer, cuDeviceCanAccessPeer, true, NO_FLAG, P4, "DPCT1031")
ENTRY(cuDeviceGetP2PAttribute, cuDeviceGetP2PAttribute, false, NO_FLAG, P4, "comment")
ENTRY(cuDevicePrimaryCtxGetState, cuDevicePrimaryCtxGetState, false, NO_FLAG, P4, "comment")
Expand Down
14 changes: 14 additions & 0 deletions clang/lib/DPCT/APINamesMemory.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,20 @@ CONDITIONAL_FACTORY_ENTRY(
"You can migrate the code with peer access extension by not specifying "
"-no-dpcpp-extensions=peer_access."))

CONDITIONAL_FACTORY_ENTRY(
UsePeerAccess(),
ASSIGNABLE_FACTORY(MEMBER_CALL_FACTORY_ENTRY(
"cuCtxEnablePeerAccess",
CALL(MapNames::getDpctNamespace() + "get_current_device"), false,
"ext_oneapi_enable_peer_access",
MEMBER_CALL(CALL(MapNames::getDpctNamespace() + "dev_mgr::instance"), false,
"get_device", ARG_WC(0)))),
REMOVE_API_FACTORY_ENTRY_WITH_MSG(
"cuCtxEnablePeerAccess",
"SYCL currently does not support memory access across peer devices. "
"You can migrate the code with peer access extension by not specifying "
"-no-dpcpp-extensions=peer_access."))

CALL_FACTORY_ENTRY(
"make_cudaExtent",
CALL(DpctGlobalInfo::getCtadClass(MapNames::getClNamespace() + "range", 3),
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/DPCT/ASTTraversal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6243,7 +6243,7 @@ void FunctionCallRule::registerMatcher(MatchFinder &MF) {
"cudaPointerGetAttributes", "cuCtxSetCacheConfig", "cuCtxSetLimit",
"cudaCtxResetPersistingL2Cache", "cuCtxResetPersistingL2Cache",
"cudaStreamSetAttribute", "cudaStreamGetAttribute", "cudaProfilerStart",
"cudaProfilerStop", "__trap");
"cudaProfilerStop", "__trap", "cuCtxEnablePeerAccess");
};

MF.addMatcher(
Expand Down
4 changes: 4 additions & 0 deletions clang/test/dpct/disable-all-extensions.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,10 @@ int peer_access() {
// CHECK: DPCT1026:{{[0-9]+}}: The call to cudaDeviceDisablePeerAccess was removed because SYCL currently does not support memory access across peer devices. You can migrate the code with peer access extension by not specifying -no-dpcpp-extensions=peer_access.
// CHECK: */
cudaDeviceDisablePeerAccess(0);
// CHECK: /*
// CHECK: DPCT1026:{{[0-9]+}}: The call to cuCtxEnablePeerAccess was removed because SYCL currently does not support memory access across peer devices. You can migrate the code with peer access extension by not specifying -no-dpcpp-extensions=peer_access.
// CHECK: */
cuCtxEnablePeerAccess(0, 0);

return 0;
}
Expand Down
3 changes: 3 additions & 0 deletions clang/test/dpct/driver_context.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ int main(){
// CHECK: MY_SAFE_CALL(DPCT_CHECK_ERROR(dpct::select_device(ctx)));
MY_SAFE_CALL(cuCtxSetCurrent(ctx));

// CHECK: dpct::get_current_device().ext_oneapi_enable_peer_access(dpct::dev_mgr::instance().get_device(ctx2));
cuCtxEnablePeerAccess(ctx2, 0);

// CHECK: ctx2 = dpct::dev_mgr::instance().current_device_id();
cuCtxGetCurrent(&ctx2);

Expand Down