Skip to content

[SYCLomatic] Redeclare variable in command group scope if it has derived-to-base/constructor-conversion/user-defined-conversion implicit cast in original code#2179

Merged
ziranzha merged 10 commits intooneapi-src:SYCLomaticfrom
zhiweij1:base_class
Jul 24, 2024

Conversation

@zhiweij1
Copy link
Copy Markdown
Contributor

@zhiweij1 zhiweij1 commented Jul 18, 2024

Signed-off-by: Jiang, Zhiwei zhiwei.jiang@intel.com

zhiweij1 added 5 commits July 16, 2024 15:59
1
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
q
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
2
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
@zhiweij1 zhiweij1 marked this pull request as ready for review July 18, 2024 06:29
@zhiweij1 zhiweij1 requested a review from a team as a code owner July 18, 2024 06:29
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
@zhiweij1 zhiweij1 changed the title Base class [SYCLomatic] Redeclare variable if has derived-to-base implicit cast Jul 18, 2024
@zhiweij1 zhiweij1 changed the title [SYCLomatic] Redeclare variable if has derived-to-base implicit cast [SYCLomatic] Redeclare variable in command group scope if it has derived-to-base implicit cast in original code Jul 18, 2024
zhiweij1 added 2 commits July 18, 2024 14:56
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
Copy link
Copy Markdown
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiweij1 zhiweij1 changed the title [SYCLomatic] Redeclare variable in command group scope if it has derived-to-base implicit cast in original code [SYCLomatic] Redeclare variable in command group scope if it has derived-to-base/constructor-conversion/user-defined-conversion implicit cast in original code Jul 23, 2024
@ziranzha ziranzha merged commit a124650 into oneapi-src:SYCLomatic Jul 24, 2024
@zhiweij1 zhiweij1 deleted the base_class branch July 24, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants