[SYCLomatic] Fix the --codepin-report when call the python command on Windows platform.#2246
Merged
zhimingwang36 merged 11 commits intooneapi-src:SYCLomaticfrom Sep 2, 2024
Merged
Conversation
… Windows platform. Signed-off-by: Chen, Sheng S <sheng.s.chen@intel.com>
ShengchenJ
changed the title
zhiweij1
approved these changes
Aug 14, 2024
tangjj11
reviewed
Aug 20, 2024
Signed-off-by: Chen, Sheng S <sheng.s.chen@intel.com>
tangjj11
approved these changes
Aug 21, 2024
ziranzha
reviewed
Aug 29, 2024
|
|
||
| std::string | ||
| GetFirstAvailableTool(std::unordered_set<std::string> &ToolCandidates) { | ||
| const char *EnvPath = std::getenv("PATH"); |
Contributor
There was a problem hiding this comment.
Try using std::string::find to extract path and then check available one by one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Windows platform.