[SYCLomatic] Support memory APIs migration with syclcompat#2286
Merged
zhimingwang36 merged 5 commits intooneapi-src:SYCLomaticfrom Aug 30, 2024
Merged
[SYCLomatic] Support memory APIs migration with syclcompat#2286zhimingwang36 merged 5 commits intooneapi-src:SYCLomaticfrom
zhimingwang36 merged 5 commits intooneapi-src:SYCLomaticfrom
Conversation
| std::string MemoryMigrationRule::getMemoryHelperFunctionName(StringRef Name) { | ||
| return dpct::getMemoryHelperFunctionName(Name); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Please add lit test for this PR.
Signed-off-by: Ziran Zhang <ziran.zhang@intel.com>
| @@ -0,0 +1,1090 @@ | |||
| // FIXME | |||
Contributor
Author
There was a problem hiding this comment.
Copy from the original lit test. Will remove it.
| @@ -0,0 +1,1090 @@ | |||
| // FIXME | |||
| // UNSUPPORTED: system-windows | |||
Contributor
There was a problem hiding this comment.
Have you built the migrated result for the 2 lit cases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.