Skip to content

[SYCLomatic] Fix enum CU_TR_* migarion when found as DeclRefExpr#2318

Merged
zhimingwang36 merged 3 commits intooneapi-src:SYCLomaticfrom
the-slow-one:6597_fix_cu_tr_enum_migration
Sep 5, 2024
Merged

[SYCLomatic] Fix enum CU_TR_* migarion when found as DeclRefExpr#2318
zhimingwang36 merged 3 commits intooneapi-src:SYCLomaticfrom
the-slow-one:6597_fix_cu_tr_enum_migration

Conversation

@the-slow-one
Copy link
Copy Markdown

@the-slow-one the-slow-one commented Sep 4, 2024

When the CU_TR_ADDRESS_MODE_WRAP and CU_TR_FILTER_MODE_POINT are not migrated due to mismatch in enum name. This PR fixes it.

Signed off by: Deepak Raj H R

@the-slow-one the-slow-one requested a review from a team as a code owner September 4, 2024 05:26
@the-slow-one the-slow-one requested review from TejaX-Alaghari, tangjj11, wenhuiNi and zhiweij1 and removed request for a team, wenhuiNi and zhiweij1 September 4, 2024 05:26
Copy link
Copy Markdown
Contributor

@TejaX-Alaghari TejaX-Alaghari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@tangjj11 tangjj11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@the-slow-one
Copy link
Copy Markdown
Author

The failed test are not not due to the change in this PR. See below.

w:\dir\workspace\SYCLomatic_CI\Win_GPU\c2s_test_opt_gpu\test_workspace\help_function\option_gpu\image_wrapper\image_wrapper.cpp(102,11): error: 'create_image' is a private member of 'dpct::image_wrapper<sycl::vec<float, 4>, 2>'
[2024-09-04T12:06:05.703Z]   102 |     tex42.create_image();

@zhimingwang36 zhimingwang36 merged commit 00c266b into oneapi-src:SYCLomatic Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants