Skip to content

[SYCLomatic] Add support to multi-device for class dpct::device_memory#2320

Merged
zhimingwang36 merged 2 commits intooneapi-src:SYCLomaticfrom
ziranzha:memory
Sep 9, 2024
Merged

[SYCLomatic] Add support to multi-device for class dpct::device_memory#2320
zhimingwang36 merged 2 commits intooneapi-src:SYCLomaticfrom
ziranzha:memory

Conversation

@ziranzha
Copy link
Copy Markdown
Contributor

@ziranzha ziranzha commented Sep 4, 2024

No description provided.

@ziranzha ziranzha requested a review from a team as a code owner September 4, 2024 07:25
@ziranzha ziranzha force-pushed the memory branch 3 times, most recently from 78db883 to 1446a83 Compare September 6, 2024 07:11
Signed-off-by: Ziran Zhang <ziran.zhang@intel.com>
Copy link
Copy Markdown
Contributor

@AndyCHHuang AndyCHHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

value_t *get_ptr() {
return get_ptr(get_default_queue());
}
value_t *get_ptr() { return get_ptr(get_default_queue()); }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change to this line, please don't include code format change.

Copy link
Copy Markdown
Contributor

@zhimingwang36 zhimingwang36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhimingwang36 zhimingwang36 merged commit 23edb09 into oneapi-src:SYCLomatic Sep 9, 2024
@ziranzha ziranzha deleted the memory branch September 9, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants