Skip to content

[SYCLomatic] EOF terminates token traversal to avoid infinite loop#2370

Merged
zhimingwang36 merged 7 commits intooneapi-src:SYCLomaticfrom
the-slow-one:7149_dpct_hangs_on_win
Sep 25, 2024
Merged

[SYCLomatic] EOF terminates token traversal to avoid infinite loop#2370
zhimingwang36 merged 7 commits intooneapi-src:SYCLomaticfrom
the-slow-one:7149_dpct_hangs_on_win

Conversation

@the-slow-one
Copy link
Copy Markdown

@the-slow-one the-slow-one commented Sep 20, 2024

While looking for "volatile" token, terminate at EOF token. If we don't do this explicitly Lexer::getRawToken keeps returning EOF on every subsequent invocation.

Signed by: Deepak Raj H R

@the-slow-one the-slow-one requested a review from a team as a code owner September 20, 2024 09:50
@the-slow-one the-slow-one requested review from intwanghao, zhiweij1 and ziranzha and removed request for ziranzha September 20, 2024 09:50
@zhimingwang36
Copy link
Copy Markdown
Contributor

Please fix the clang-format

Copy link
Copy Markdown
Contributor

@AndyCHHuang AndyCHHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the implementation looks good to me.

consider making the 4000+ lines dummy char into the same line.
but it's optional.

@the-slow-one
Copy link
Copy Markdown
Author

Failed tests are unrelated to this PR

[2024-09-24T17:11:24.336Z] Failed Tests (5):
[2024-09-24T17:11:24.336Z]   Clang :: dpct/codepin/report/change_floating_point_default_tolerances/test.cpp
[2024-09-24T17:11:24.336Z]   Clang :: dpct/codepin/report/dismatch_format/test.cpp
[2024-09-24T17:11:24.336Z]   Clang :: dpct/codepin/report/floating_point_compare/test.cpp
[2024-09-24T17:11:24.336Z]   Clang :: dpct/codepin/report/option/test.cpp
[2024-09-24T17:11:24.336Z]   Clang :: dpct/fix_internal_error_2.cu
[2024-09-24T17:11:24.336Z] 

@zhimingwang36 zhimingwang36 merged commit 2a5d0e6 into oneapi-src:SYCLomatic Sep 25, 2024
@the-slow-one the-slow-one deleted the 7149_dpct_hangs_on_win branch November 18, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants