[SYCLomatic] EOF terminates token traversal to avoid infinite loop#2370
Merged
zhimingwang36 merged 7 commits intooneapi-src:SYCLomaticfrom Sep 25, 2024
the-slow-one:7149_dpct_hangs_on_win
Merged
[SYCLomatic] EOF terminates token traversal to avoid infinite loop#2370zhimingwang36 merged 7 commits intooneapi-src:SYCLomaticfrom the-slow-one:7149_dpct_hangs_on_win
zhimingwang36 merged 7 commits intooneapi-src:SYCLomaticfrom
the-slow-one:7149_dpct_hangs_on_win
Conversation
Contributor
|
Please fix the clang-format |
AndyCHHuang
approved these changes
Sep 24, 2024
Contributor
AndyCHHuang
left a comment
There was a problem hiding this comment.
the implementation looks good to me.
consider making the 4000+ lines dummy char into the same line.
but it's optional.
zhiweij1
approved these changes
Sep 24, 2024
Author
|
Failed tests are unrelated to this PR |
ziranzha
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking for "volatile" token, terminate at EOF token. If we don't do this explicitly
Lexer::getRawTokenkeeps returning EOF on every subsequent invocation.Signed by: Deepak Raj H R