Skip to content

[SYCLomatic][CMake] Add rule to migrate cuda_compile without libtype #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ziranzha merged 3 commits into from
Nov 29, 2024
Merged

[SYCLomatic][CMake] Add rule to migrate cuda_compile without libtype #2523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa31322
[SYCLomatic][CMake] Add rule to migrate cuda_compile without linkage
daiyaan-ahmed6 Nov 28, 2024
f43cbb1
Fix CMake LIT test
daiyaan-ahmed6 Nov 28, 2024
a425660
Fix CMake rule
daiyaan-ahmed6 Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clang/test/dpct/cmake_migration/case_018/expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ dpct_helper_sycl_compile(obj3 f1.dp.cpp f2.dp.cpp f3.dp.cpp)
dpct_helper_sycl_compile(obj4 a.dp.cpp b.dp.cpp)

dpct_helper_sycl_compile(obj5 a.dp.cpp b.dp.cpp)

dpct_helper_sycl_compile(obj6 a.dp.cpp b.dp.cpp)
2 changes: 2 additions & 0 deletions clang/test/dpct/cmake_migration/case_018/input.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ cuda_compile(obj3 f1.cu f2.cu f3.cu SHARED)
cuda_compile(obj4 a.cu b.cu STATIC OPTIONS -O3 --profile)

cuda_compile(obj5 a.cu b.cu SHARED OPTIONS -O3 --profile)

cuda_compile(obj6 a.cu b.cu OPTIONS -O3 --profile)
10 changes: 9 additions & 1 deletion clang/tools/dpct/DpctOptRules/cmake_script_migration_rule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,11 +664,19 @@
In: cuda_compile(${libname} ${srcs} SHARED)
Out: dpct_helper_sycl_compile(${libname} ${srcs})

- Rule: rule_cuda_compile_with_no_opts
- Rule: rule_cuda_compile_with_opts_without_lib_type
Kind: CMakeRule
Priority: Fallback
MatchMode: Partial
CmakeSyntax: rule_cuda_compile_05
In: cuda_compile(${libname} ${srcs} OPTIONS ${opts})
Out: dpct_helper_sycl_compile(${libname} ${srcs})

- Rule: rule_cuda_compile
Kind: CMakeRule
Priority: Fallback
MatchMode: Partial
CmakeSyntax: rule_cuda_compile_06
In: cuda_compile(${libname} ${srcs})
Out: dpct_helper_sycl_compile(${libname} ${srcs})

Expand Down