Skip to content

[SYCLomatic] Fix thrust::device_reference lit test#350

Merged
zhimingwang36 merged 1 commit intooneapi-src:SYCLomaticfrom
jzc:lit-fix
Nov 11, 2022
Merged

[SYCLomatic] Fix thrust::device_reference lit test#350
zhimingwang36 merged 1 commit intooneapi-src:SYCLomaticfrom
jzc:lit-fix

Conversation

@jzc
Copy link
Copy Markdown
Contributor

@jzc jzc commented Nov 9, 2022

Signed-off-by: Cai, Justin justin.cai@intel.com

Signed-off-by: Cai, Justin <justin.cai@intel.com>
@jzc jzc requested a review from a team as a code owner November 9, 2022 17:16
@jzc jzc marked this pull request as draft November 11, 2022 00:15
Copy link
Copy Markdown
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhimingwang36 zhimingwang36 marked this pull request as ready for review November 11, 2022 01:24
@zhimingwang36 zhimingwang36 merged commit 8cdea07 into oneapi-src:SYCLomatic Nov 11, 2022
// RUN: grep "IsCalled" %T/DplExtrasMemory/api_test11_out/MainSourceFiles.yaml | wc -l > %T/DplExtrasMemory/api_test11_out/count.txt
// RUN: FileCheck --input-file %T/DplExtrasMemory/api_test11_out/count.txt --match-full-lines %s
// RUN: rm -rf %T/DplExtrasMemory/api_test11_out

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the justification for changing the check result from 37 to 38? I didn't see anything in the commit message explaining why the test result should change.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR (#319) branched from a969b47, and then when it was merged and rebased, the changes were applied to a history which included the commit 9ce844b, which changed the counts.

ShengchenJ pushed a commit to ShengchenJ/SYCLomatic that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants