Skip to content

[SYCLomatic] Change io_iterator_pair accessor naming and add do_swap_iters argument#588

Merged
0x12CC merged 4 commits intooneapi-src:SYCLomaticfrom
jzc:io_iterator_pair-naming
Feb 14, 2023
Merged

[SYCLomatic] Change io_iterator_pair accessor naming and add do_swap_iters argument#588
0x12CC merged 4 commits intooneapi-src:SYCLomaticfrom
jzc:io_iterator_pair-naming

Conversation

@jzc
Copy link
Copy Markdown
Contributor

@jzc jzc commented Feb 10, 2023

Signed-off-by: Cai, Justin justin.cai@intel.com

@jzc jzc requested a review from a team as a code owner February 10, 2023 19:54
@jzc jzc requested a review from danhoeflinger February 10, 2023 19:55
Comment thread clang/runtime/dpct-rt/include/dpl_extras/algorithm.h.inc
Copy link
Copy Markdown
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

segmented_sort_pairs needs the same adjustment for .input() and .output() as well as the swapping code.

Copy link
Copy Markdown
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread clang/runtime/dpct-rt/include/dpl_extras/algorithm.h.inc
Comment thread clang/test/dpct/helper_files_ref/include/dpl_extras/algorithm.h
Copy link
Copy Markdown
Contributor

@yihwang-nv yihwang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x12CC 0x12CC merged commit 97b7ccb into oneapi-src:SYCLomatic Feb 14, 2023
ShengchenJ pushed a commit to ShengchenJ/SYCLomatic that referenced this pull request Sep 27, 2024
Signed-off-by: ChungHao Huang <andy.huang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants