Skip to content

[SYCLomatic] Fix 4 thrust migration LIT test fails on CUDA 11.2+#66

Merged
zhimingwang36 merged 1 commit intooneapi-src:SYCLomaticfrom
delecui:fix_thrust_lit_fails_cuda11.2_plus
Jun 9, 2022
Merged

[SYCLomatic] Fix 4 thrust migration LIT test fails on CUDA 11.2+#66
zhimingwang36 merged 1 commit intooneapi-src:SYCLomaticfrom
delecui:fix_thrust_lit_fails_cuda11.2_plus

Conversation

@delecui
Copy link
Contributor

@delecui delecui commented Jun 8, 2022

Signed-off-by: Cui, Dele dele.cui@intel.com

Signed-off-by: Cui, Dele <dele.cui@intel.com>
@delecui delecui requested a review from a team as a code owner June 8, 2022 06:07
// UNSUPPORTED: cuda-8.0
// UNSUPPORTED: v8.0
// RUN: dpct --format-range=none -out-root %T/thrust-for-h2o4gpu %s --cuda-include-path="%cuda-path/include" -- -std=c++14 -x cuda --cuda-host-only -fno-delayed-template-parsing
// RUN: dpct --format-range=none -out-root %T/thrust-for-h2o4gpu %s --cuda-include-path="%cuda-path/include" -- -std=c++14 -x cuda --cuda-host-only -fno-delayed-template-parsing -ferror-limit=50
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-ferror-limit=50 is to allow more parsing errors than default 20, otherwise dpct will stop migration due to two many errors if CUDA_PATH is 11.2~11.7

For dpct/thrust-for-h2o4gpu:
16 parsing errors are reported with CUDA_PATH set to 11.0 and 11.1.
22 parsing errors are reported with CUDA_PATH set to 11.2+.

If "-ferror-limit" is not passed, the error limit is 20 by default.

The other 3 LIT tests have the same issue.

Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ShengchenJ ShengchenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ziranzha ziranzha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DoyleLi DoyleLi closed this Jun 8, 2022
@DoyleLi DoyleLi reopened this Jun 8, 2022
@DoyleLi
Copy link
Contributor

DoyleLi commented Jun 8, 2022

So sorry for clicking it by mistake

Copy link
Contributor

@zhimingwang36 zhimingwang36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhimingwang36 zhimingwang36 merged commit 05ceacf into oneapi-src:SYCLomatic Jun 9, 2022
@delecui delecui deleted the fix_thrust_lit_fails_cuda11.2_plus branch August 16, 2022 14:54
ShengchenJ pushed a commit to ShengchenJ/SYCLomatic that referenced this pull request Sep 27, 2024
ShengchenJ pushed a commit to ShengchenJ/SYCLomatic that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants