Skip to content

Conversation

@0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Mar 9, 2023

Signed-off-by: Michael Aziz michael.aziz@intel.com

@0x12CC 0x12CC requested a review from a team as a code owner March 9, 2023 18:48
@0x12CC 0x12CC requested review from ShengchenJ and ziranzha March 9, 2023 18:48
@0x12CC
Copy link
Contributor Author

0x12CC commented Mar 9, 2023

End-to-end tests: oneapi-src/SYCLomatic-test#256

Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @0x12CC, the migration of device ID and UUID should follow the same way of migrating cudaMemGetInfo(), which also uses Intel's Extensions for Device Information "sycl::ext::intel::info::device::free_memory", and the behavior is controlled by option "--no-dpcpp-extensions=device_info".

Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC 0x12CC requested a review from tomflinda March 10, 2023 21:22
Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x12CC 0x12CC merged commit 84cc0ac into oneapi-src:SYCLomatic Mar 14, 2023
@0x12CC 0x12CC deleted the device_info branch March 14, 2023 13:57
ShengchenJ pushed a commit to ShengchenJ/SYCLomatic that referenced this pull request Sep 27, 2024
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
ShengchenJ pushed a commit to ShengchenJ/SYCLomatic that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support device UUID query DPCT1051: support the query of a device ID

3 participants