Skip to content

Conversation

@ShengchenJ
Copy link
Contributor

@ShengchenJ ShengchenJ commented May 23, 2023

If the compute capability is higher than 8.0, the block_tile_memory function can be omitted. Therefore, in the migration code, the function is removed directly. As for the this_thread_block function, migrate it directly to the experimental::this_sub_group() free queries function, regardless of whether the function needs input parameters or not.

Signed-off-by: Chen, Sheng S sheng.s.chen@intel.com

@ShengchenJ ShengchenJ requested a review from a team as a code owner May 23, 2023 09:24
If the compute capability is higher than 8.0, the `block_tile_memory` function can be omitted. Therefore, in the migration code, the function is removed directly. As for the `this_thread_block` function, migrate it directly to the `experimental::this_sub_group()` free queries function, regardless of whether the function needs input parameters or not.

Signed-off-by: Chen, Sheng S <sheng.s.chen@intel.com>
Signed-off-by: Chen, Sheng S <sheng.s.chen@intel.com>
Copy link
Contributor

@zhimingwang36 zhimingwang36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhimingwang36 zhimingwang36 merged commit 0aee6f8 into oneapi-src:SYCLomatic Jun 2, 2023
@ShengchenJ ShengchenJ deleted the block_tile branch July 2, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants