IRTK embree pathtracer fixes for stb (2024.0) #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carroll, Michael R <michael.r.carroll@intel.com>
… in cmake Signed-off-by: Carroll, Michael R <michael.r.carroll@intel.com>
jimmytwei
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Fixed RenderingToolkit/Tutorial/PathTracingWithEmbree sample for flat dirs... CMakeLists.txt and README.md updated.
Old and new vars files work OK.
CMakeLists: VS_DEBUGGER_ENVIRONMENT property appears to give bugged MSVS project generation per forums discussion, but probably best to leave it in the cmake file.
Fixes Issue#
ONSAM-1708
External Dependencies
Embree now requires sycl DSO even for CPU only targets. Added to README.md. Changed README to use new oneapi-vars.bat file.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Tested both oneapi-vars.bat and setvars.bat with a self-manually created pacakage for flatdirs, versions:
w_RenderKit_p_2024.0.0.49617 and w_RenderKit_p_2024.0.0.49617