IRTK 2024.0 fixes for Tutorials/IntroToRayTracingWithEmbree (CPU and GPU) #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carroll, Michael R <michael.r.carroll@intel.com>
Signed-off-by: MichaelRoyceCarroll <michael.carroll@alumni.usc.edu>
jimmytwei
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Required updates to build this tutorial sample with the 2024.0 release of IRTK. This is one "sample" that has both cpu and gpu targets. The only files that have changed are CMakeLists.txt README.md and a helper script to launch the MSVS toolchain build for 2024.0 compiler.
Fixes Issue#
N/A (No ticket)
External Dependencies
Embree relies on sycl DSO even in CPU mode. This should be included in path automatically with toolkit vars.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Tested on Windows w 2024.0 on CPU, and GPU (NMake and deprecated MSVS Toolchain)