Closed
Conversation
with gcc 13 there is this error
oneDNN/src/cpu/aarch64/xbyak_aarch64/xbyak_aarch64/xbyak_aarch64.h:70:7: error: ‘uint64_t’ does not name a type
70 | const uint64_t SP_IDX = 31;
| ^~~~~~~~
oneDNN/src/cpu/aarch64/xbyak_aarch64/xbyak_aarch64/xbyak_aarch64.h:56:1: note: ‘uint64_t’ is defined in
header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
55 | #include <sstream>
+++ |+#include <cstdint>
So include cstdint.
Signed-off-by: Tom Rix <trix@redhat.com>
Contributor
|
Please open the PR upstream: https://github.com/fujitsu/xbyak_aarch64 |
Contributor
|
It's already merged at fujitsu/xbyak_aarch64@0b04d5b . |
Contributor
|
And should be fixed by #1557 |
Author
|
I agree fixing should be done in the upstream. There are several intel projects that embed xbyak source within the project. Both xbyak and xbyak_aarch64 are a available in fedora. Would folks be interested in have a USE_SYSTEM_XBYAK cmake option ? So when I fix xbyak in fedora, OneDNN will get it . |
Contributor
|
@trixirt, oneDNN implementation heavily relies on Xbyak features and may not compile with older versions. This is the main reason it's embedded into the codebase instead of used as a dependency. |
Contributor
|
May the PR be closed since #1557 landed? |
Contributor
|
Fixed by #1557. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with gcc 13 there is this error
oneDNN/src/cpu/aarch64/xbyak_aarch64/xbyak_aarch64/xbyak_aarch64.h:70:7: error: ‘uint64_t’ does not name a type
70 | const uint64_t SP_IDX = 31;
| ^~~~~~~~
oneDNN/src/cpu/aarch64/xbyak_aarch64/xbyak_aarch64/xbyak_aarch64.h:56:1: note: ‘uint64_t’ is defined in
header ‘’; did you forget to ‘#include ’?
55 | #include
+++ |+#include
So include cstdint.
Description
Please include a summary of the change. Please also include relevant motivation and context. See contribution guidelines for more details. If the change fixes an issue not documented in the project's Github issue tracker, please document all steps necessary to reproduce it.
Fixes # (github issue)
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?Performance improvements
New features
Bug fixes
RFC PR