Add sles15 to multi numa ci #1007
Conversation
|
using static hwloc linking (changes: https://github.com/intel12232289/unified-memory-framework/blob/refs/heads/Add-SLES15-to-multi-NUMA-C/.github/workflows/reusable_multi_numa.yml#L49 ) we got issues in testing, is this expected? @ldorau, for the help? 😉 |
I think it is not, since it works correctly on Ubuntu 22.04; |
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
ok, @intel12232289 it looks like there's some issue we may not understand.
Please make it as it was before - run only selected tests (similarly to RHEL), and please make the PR ready for review & merge
| name: "${{matrix.os}}, ${{matrix.build_type}}, shared=${{matrix.shared_library}}" | ||
| # run only on upstream; forks will not have the HW | ||
| if: github.repository == 'oneapi-src/unified-memory-framework' | ||
| # if: github.repository == 'oneapi-src/unified-memory-framework' |
There was a problem hiding this comment.
pls uncomment this
There was a problem hiding this comment.
you can uncomment this now
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Since we're ready with the machine, please cleanup the PR (see my issues) and we can un-draft it.
| @@ -1,4 +1,4 @@ | |||
| # Runs tests on multi-numa machine | |||
| # Runs tests on multi-numa machines1 | |||
There was a problem hiding this comment.
machines1 misspell
| name: "${{matrix.os}}, ${{matrix.build_type}}, shared=${{matrix.shared_library}}" | ||
| # run only on upstream; forks will not have the HW | ||
| if: github.repository == 'oneapi-src/unified-memory-framework' | ||
| # if: github.repository == 'oneapi-src/unified-memory-framework' |
There was a problem hiding this comment.
you can uncomment this now
| # Runs tests on multi-numa machine | ||
| # Runs tests on multi-numa machines1 | ||
| name: MultiNuma | ||
|
|
There was a problem hiding this comment.
pls squash all your commits into a single one, with a proper description what this commit does
ghost
mentioned this pull request
|
I will close this one. Too much conflicts during squashing |
ghost
closed this
2 participants
Add sles15 to multi numa ci