Add sles15 to multi numa c final #1037
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
ghost
mentioned this pull request
lukaszstolarczuk
requested changes
Jan 14, 2025
| name: "${{matrix.os}}, ${{matrix.build_type}}, shared=${{matrix.shared_library}}" | ||
| # run only on upstream; forks will not have the HW | ||
| if: github.repository == 'oneapi-src/unified-memory-framework' | ||
|
|
Contributor
There was a problem hiding this comment.
pls update comment on top:
# Runs tests on multi-numa machine -> # Runs tests on multi-numa machines (plural)
| name: "${{matrix.os}}, ${{matrix.build_type}}, shared=${{matrix.shared_library}}" | ||
| # run only on upstream; forks will not have the HW | ||
| if: github.repository == 'oneapi-src/unified-memory-framework' | ||
|
|
Contributor
There was a problem hiding this comment.
as I mentioned before - pls update commits, to only have a single one, with proper description. Message Update reusable_multi_numa.yml doesn't say much 😉
added 3 commits
January 14, 2025 14:30
…232289/unified-memory-framework into Add-SLES15-to-multi-NUMA-C-FINAL
ghost
mentioned this pull request
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SLES support.
Older conversation at #1007 (review)
https://github.com/intel12232289/unified-memory-framework/actions/runs/12767806141/job/35587841005
https://github.com/intel12232289/unified-memory-framework/actions/runs/12767806141/job/35587841609
https://github.com/intel12232289/unified-memory-framework/actions/runs/12767806141/job/35587842189
https://github.com/intel12232289/unified-memory-framework/actions/runs/12767806141/job/35587842525