Skip to content

Add sles15 to multi numa c final #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add sles15 to multi numa c final #1037

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d03fe8
Update reusable_multi_numa.yml
Jan 14, 2025
580b9d3
Update reusable_multi_numa.yml
Jan 14, 2025
2faf0dc
Update reusable_multi_numa.yml
Jan 14, 2025
a7a88fe
Update reusable_multi_numa.yml (+1 squashed commits)
Jan 14, 2025
a13cb35
Merge branch 'Add-SLES15-to-multi-NUMA-C-FINAL' of github.com:intel12…
Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/reusable_multi_numa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Runs tests on multi-numa machine
# Runs tests on multi-numa machines
name: MultiNuma

on: [workflow_call]
Expand All @@ -19,7 +19,7 @@ jobs:

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update comment on top:

# Runs tests on multi-numa machine -> # Runs tests on multi-numa machines (plural)

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I mentioned before - pls update commits, to only have a single one, with proper description. Message Update reusable_multi_numa.yml doesn't say much 😉

strategy:
matrix:
os: [ubuntu-22.04, rhel-9.1]
os: [ubuntu-22.04, rhel-9.1, sles-15]
build_type: [Debug, Release]
shared_library: ['ON', 'OFF']
runs-on: ["DSS-MULTI-NUMA", "DSS-${{matrix.os}}"]
Expand Down Expand Up @@ -53,15 +53,15 @@ jobs:
run: cmake --build ${{github.workspace}}/build -j $(nproc)

- name: Run tests
if: matrix.os != 'rhel-9.1'
if: (matrix.os != 'rhel-9.1') && (matrix.os != 'sles-15')
working-directory: ${{github.workspace}}/build
run: ctest --output-on-failure --test-dir test

# On RHEL, hwloc version is just a little too low.
# On RHEL/SLES, hwloc version is just a little too low.
# Skip some tests until we upgrade hwloc and update CMake to properly handle local hwloc installation.
# TODO: fix issue #560
- name: Run tests (on RHEL)
if: matrix.os == 'rhel-9.1'
- name: Run tests (on RHEL/SLES15)
if: (matrix.os == 'rhel-9.1') || (matrix.os == 'sles-15')
working-directory: ${{github.workspace}}/build
run: |
ctest --output-on-failure --test-dir test -E "umf-provider_os_memory_multiple_numa_nodes"
Expand Down