[ur] unify usm_advice naming #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
approved these changes
Mar 24, 2023
kbenzie
approved these changes
Mar 29, 2023
scripts/core/event.yml
Outdated
| desc: Event created by $xEnqueueUSMPrefetch | ||
| - name: USM_MEM_ADVISE | ||
| desc: Event created by $xEnqueueUSMMemAdvise | ||
| - name: USM_USM_ADVISE |
Contributor
There was a problem hiding this comment.
I don't think USM needs to be repeated, should this be USM_ADVISE instead?
Contributor
Author
There was a problem hiding this comment.
Right, I missed that, fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions and enumerators were called
*USMMemAdvisewhile the type was calledur_mem_advice_t(without USM). Unify the naming by usingusm_advice/USMAdviseeverywhere.