feat: mark OrgRule endpoint fields optional for app-permission rules#47
Merged
Conversation
Rule listings mix custom rules (which carry hostPattern/pathPattern/method) with app-permission rules, which omit those endpoint fields and are identified by metadata.provider + metadata.toolId. Type OrgRule accordingly, document the two kinds in the README, and pin the mixed-list decode in a test. Inputs (CreateOrgRuleInput/UpdateOrgRuleInput) are unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
OrgRule.hostPattern/pathPattern/methodbecome optional: present on custom (user-authored) rules, omitted on app-permission rules, which are identified bymetadata.provider+metadata.toolId(JSDoc added).Inputs (
CreateOrgRuleInput/UpdateOrgRuleInput) are unchanged; runtime behavior is a pass-through as before — this is a type-accuracy release.Merge order
Server side ships first: onecli/onecli-cloud#626 (merge + deploy), then this PR any time after. Sibling CLI PR: onecli/onecli-cli#91.
Gates:
pnpm typecheck,pnpm test(88 tests),pnpm build— all green.🤖 Generated with Claude Code