fix: settings nav org-awareness and proxy cookie validation - #316
Merged
Conversation
- Settings nav and mobile nav now derive sections dynamically via getSettingsSections(orgId) instead of static import, enabling org-scoped settings URLs when orgId is present in the pathname - Dashboard layout isSettings check expanded to match /org/*/settings paths - Proxy middleware no longer sets default-org cookie (moved to validated client component to prevent cookie poisoning from invalid org URLs) - nav-config exports getSettingsSections function alongside static array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSettingsSections(orgId)instead of staticsettingsSectionsimport, enabling org-scoped URLs when an org ID is present in the pathnameisSettingscheck expanded to also match/org/*/settingspathsnav-config.tsexportsgetSettingsSections()function alongside backward-compatiblesettingsSectionsstatic arrayChanged files (6)
layout.tsx— isSettings regex for org settings pathssettings-nav.tsx/settings-mobile-nav.tsx— dynamic sections fromgetSettingsSections(orgId)nav-config.ts—getSettingsSections(orgId?)function exportproxy.ts— removed cookie setting from middlewarenot-found.tsx— minor update