feat: support alternate connection methods and expand the app catalog#398
Merged
Conversation
Connections - App definitions can declare `additionalMethods` alongside the primary `connectionMethod`. The credentials-connect route resolves the requested `method` (e.g. an API-key option offered next to OAuth) and rejects an explicit but unrecognized method instead of silently falling back. - Surface `resolveMetadata` validation failures to the user as a 400 with the underlying message rather than a generic error. - Add optional `helpUrl`/`helpLabel` hints for connection fields and a custom-credentials entry point in the connect flow. App catalog - Add Attio and X (Twitter) catalog entries with light/dark icons. - Pass ATTIO_CLIENT_ID/SECRET through the turbo env allowlist. Secrets - Drop the unused `is_platform` column end to end: Prisma schema and migration, the gateway `SecretRow` and its SELECTs, and the platform-secret special-casing in the secret service. - Reorder the secret dialog fields and clarify the value label. Gateway cache - Replace the server-action cache flush with a client-side `invalidateGatewayCache()` helper that calls the gateway directly and authenticates as the acting user; data hooks invoke it on mutation. Misc - Remove dead edition branches from the docker entrypoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of shared changes: alternate connection methods, a custom-credentials entry point, two new app-catalog entries, removal of the dead
is_platformsecret column, and a client-side gateway cache helper.Connections
additionalMethodsalongside the primaryconnectionMethod. The credentials-connect route resolves the requestedmethod(e.g. an API-key option offered next to OAuth) and rejects an explicit but unrecognized method instead of silently falling back.resolveMetadatavalidation failures now surface to the user as a400with the underlying message instead of a generic error.helpUrl/helpLabelhints for connection fields, plus a custom-credentials entry point in the connect flow.App catalog
ATTIO_CLIENT_ID/ATTIO_CLIENT_SECRETthrough the turbo env allowlist.Secrets
is_platformcolumn end to end: Prisma schema + migration, the gatewaySecretRowand itsSELECTs, and the platform-secret special-casing in the secret service.Gateway cache
invalidateGatewayCache()helper that calls the gateway directly and authenticates as the acting user; data hooks invoke it on mutation.Misc
Testing
pnpm check(lint + types + format across the workspace, incl.cargo clippy -- -D warnings) — greencargo fmt --check+cargo clippy --all-targetsfor the gateway — greenpnpm db:generate— schema valid; migration is a singleDROP COLUMN