Static #2
Open
Static #2
+3,220
−2,895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 081ca7a.
Merge from upstream
Add customizable accessoryView besides messageContainer
…into development
This change provides better handling of keyboard frames. It copes with different values of UIViewController.edgesForExtendedLayout, UIScrollView.contentInsetAdjumentBehavior, view controller containment scenarios and undocked keyboards, and uses cleaner code. Improvements and fixes in this change: 1. Translates keyboard frame from screen coordinates into view controller coordinates. They aren’t the same thing when containment is involved, or edgesForExtendedLayout does not include .top. 2. Avoids special casing any iPhone models and avoids dealing with safeAreaInsets manually. In iOS 11, UIScrollView may behave differently depending on contentInsetAdjumentBehavior, and the old code incorrectly assumed that the mode is .always (while it is in fact is .automatic) and that no extra safe area insets have been introduced at the bottom edge. Best part, we don’t have to deal with any of this at all, we can offload the logic to UIScrollView itself by looking at the difference between adjustedContentInset and contentInset. 3. Handles view controller containment and undocked keyboards by taking into account an intersection of the scroll view frame and the keyboard’s frame. I think Apple demoes this in one of the WWDC videos, but I couldn’t find which one (or if I’m misremembering). Regardless, this technique makes sure we compute and use a sensible number. There’s also a couple of extra renames that make the intention of the modified code clearer.
…n when compare double
…o-rule-em-all Adjust contentInset for the keyboard frame properly
Add didTapAccessoryView Delegate method and adjust layout
…ayButton Views, MessageContent, MessageCollectionView Cells, MessagesCollectionViewFlow Layout.
Fix: Allow required initializator methods @ Views.
Release MessageKit 2.0.0-beta1
* allow dynamic calculation of avatar size instead of having the same avatar size per size calculator, allow a subclass to override it so it can provide multiple avatar sizes depending on the message * make sizing functions overridable by subclasses
…ssageKind MessagesDataSource & MessagesLayoutDelegate methods for MessageType.custom
… people to use it in their own custom cell Revert "[MessageLabel] Change privacy of properties and function to use allow people to use it in their own custom cell" This reverts commit e902832. [MessageLabel] Change privacy of properties and function to use allow people to use it in their own custom cell [Update] Make handleGesture open [Update]
[MessageLabel] Change privacy of properties and function to use allow…
Moved **testMessageCollectionView_hasMessageCollectionFlowLayoutAfterViewDidLoad** to MessagesViewControlerSpec.swift and removed a duplication of this test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.