feat: add X-React-Native-Project-Root header to dev server#18
Merged
natew merged 1 commit intoonejs:mainfrom Jan 29, 2024
Merged
feat: add X-React-Native-Project-Root header to dev server#18natew merged 1 commit intoonejs:mainfrom
X-React-Native-Project-Root header to dev server#18natew merged 1 commit intoonejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
@natew wdyt about adding example to repo with bare React Native Community CLI setup? |
Collaborator
|
down for that definitely. |
zetavg
added a commit
that referenced
this pull request
Sep 29, 2024
…xpo Go on iPhone (#18) * fix: RN bundle syntax error * print QR code for opening the app on server start * [Expo Go] use a static logo for icon and splash screen * yarn install
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
To properly support
@react-native-community/clia dev server needs to return a header calledX-React-Native-Project-Rootwith path to the project root.Before:
After:
Test plan
npx react-native@latest initvxrninside projectyarn ios-> RN CLI should detect dev server on selected port.