chore(deps): update dependency ruff to v0.9.1 #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate-approve[bot]](https://avatars.githubusercontent.com/in/7394?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/ruff-0.x
branch
2 times, most recently
from
490b350 to
b028388
Compare
Contributor
|
Fixing... |
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
vlaci
force-pushed
the
renovate/ruff-0.x
branch
from
37f0c0d to
ddac207
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
chore(deps): update dependency ruff to v0.9.1
vlaci
dismissed
renovate-approve[bot]’s stale review
substantial changes accec
We have a bunch of modules inside the `unblob` package with names
colliding with standard library modules:
unblob/handlers/compression/gzip.py:1:1: A005 Module `gzip` shadows a Python standard-library module
unblob/handlers/compression/lzma.py:1:1: A005 Module `lzma` shadows a Python standard-library module
unblob/handlers/compression/zlib.py:1:1: A005 Module `zlib` shadows a Python standard-library module
unblob/logging.py:1:1: A005 Module `logging` shadows a Python standard-library module
As we never import them directly into scope (e.g. `from unblob import
logging`), due to A004 (builtin-import-shadowning), it poses low risk.
…gument lints
The following lints are false positive, but highlight a problem:
178 | @attrs.define
179 | class MultiFile(Blob):
180 | name: str = attr.field(kw_only=True)
| ^^^^^^^^^^^^^^^^^^^^^^^^ RUF009
181 | paths: list[Path] = attr.field(kw_only=True)
|
unblob/models.py:181:25: RUF009 Do not perform function call `attr.field` in dataclass defaults
|
179 | class MultiFile(Blob):
180 | name: str = attr.field(kw_only=True)
181 | paths: list[Path] = attr.field(kw_only=True)
| ^^^^^^^^^^^^^^^^^^^^^^^^ RUF009
182 |
183 | handler: "DirectoryHandler" = attr.ib(init=False, eq=False)
|
The issue is that we are using both `attrs` and legacy `attr` module
imports in the same scope.
Fixing these also introduce invalid `attrs.ib` calls as well, which
also has to be fixed
vlaci
force-pushed
the
renovate/ruff-0.x
branch
from
ddac207 to
f0482a5
Compare
`attr` is the legacy module name, containing `s` and `ib`, which are not exposed through `attrs` which also matches the package name. For reasoing, see the previous commit.
See https://astral.sh/blog/ruff-v0.9.0 for the list of changes
vlaci
force-pushed
the
renovate/ruff-0.x
branch
from
f0482a5 to
d282e4f
Compare
Contributor
qkaiser
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.8.6->0.9.1Release Notes
astral-sh/ruff (ruff)
v0.9.1Compare Source
Preview features
pycodestyle] Runtoo-many-newlines-at-end-of-fileon each cell in notebooks (W391) (#15308)ruff] Omit diagnostic for shadowed private function parameters inused-dummy-variable(RUF052) (#15376)Rule changes
flake8-bugbear] Improveassert-raises-exceptionmessage (B017) (#15389)Formatter
Server
Bug fixes
flake8-pie] Correctly remove wrapping parentheses (PIE800) (#15394)pyupgrade] Handle comments and multiline expressions correctly (UP037) (#15337)v0.9.0Compare Source
Check out the blog post for a migration guide and overview of the changes!
Breaking changes
Ruff now formats your code according to the 2025 style guide. As a result, your code might now get formatted differently. See the formatter section for a detailed list of changes.
This release doesn’t remove or remap any existing stable rules.
Stabilization
The following rules have been stabilized and are no longer in preview:
stdlib-module-shadowing(A005).This rule has also been renamed: previously, it was called
builtin-module-shadowing.builtin-lambda-argument-shadowing(A006)slice-to-remove-prefix-or-suffix(FURB188)boolean-chained-comparison(PLR1716)decimal-from-float-literal(RUF032)post-init-default(RUF033)useless-if-else(RUF034)The following behaviors have been stabilized:
pytest-parametrize-names-wrong-type(PT006): Detectpytest.parametrizecalls outside decorators and calls with keyword arguments.module-import-not-at-top-of-file(E402): Ignorepytest.importorskipcalls between import statements.mutable-dataclass-default(RUF008) andfunction-call-in-dataclass-default-argument(RUF009): Add support forattrs.bad-version-info-comparison(PYI006): Extend the rule to check non-stub files.The following fixes or improvements to fixes have been stabilized:
redundant-numeric-union(PYI041)duplicate-union-members(PYI016)Formatter
This release introduces the new 2025 stable style (#13371), stabilizing the following changes:
ISC001incompatibility warning (#15123)assertmessage over breaking the assertion expression (#9457)ifguards inmatchcaseclauses (#13513)matchcasepatterns (#6933)ifkeyword for comprehensions where the condition has a leading comment (#12282)withstatements with a single context manager for Python 3.8 or older (#10276)max-doc-code-line-length = "dynamic"(#13523)Preview features
flake8-bugbear] Implementclass-as-data-structure(B903) (#9601)flake8-type-checking] Applyquoted-type-aliasmore eagerly inTYPE_CHECKINGblocks and ignore it in stubs (TC008) (#15180)pylint] Ignoreeq-without-hashin stub files (PLW1641) (#15310)pyupgrade] SplitUP007into two individual rules:UP007forUnionandUP045forOptional(UP007,UP045) (#15313)ruff] New rule that detects classes that are both an enum and adataclass(RUF049) (#15299)ruff] RecodeRUF025toRUF037(RUF037) (#15258)Rule changes
flake8-builtins] Ignorestdlib-module-shadowingin stub files(A005) (#15350)flake8-return] Add support for functions returningtyping.Never(RET503) (#15298)Server
logLevelserver settingwhich defaults to
info. This addresses the issue where users were notified about an error and told to consult the log, but it didn’t contain any messages. (#15232)CLI
--config key=valuewhen thekeyis for a table and it’s a simplevalueBug fixes
eradicate] Ignore metadata blocks directly followed by normal blocks (ERA001) (#15330)flake8-django] Recognize other magic methods (DJ012) (#15365)pycodestyle] Avoid false positives related to type aliases (E252) (#15356)pydocstyle] Avoid treating newline-separated sections as sub-sections (D405) (#15311)pyflakes] Remove call when removing final argument fromformat(F523) (#15309)refurb] Mark fix as unsafe when the right-hand side is a string (FURB171) (#15273)ruff] Treat)as a regex metacharacter (RUF043,RUF055) (#15318)ruff] Parenthesize theint-call argument when removing theintcall would change semantics (RUF046) (#15277)Configuration
📅 Schedule: Branch creation - "* 0-3 * * 1" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.