fix(docker): system-wide install of unblob within container. #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkaiser
force-pushed
the
971-system-wide-install-container
branch
from
38b86b3 to
073dfad
Compare
kissgyorgy
requested changes
Oct 1, 2024
Contributor
kissgyorgy
left a comment
kissgyorgy
left a comment
There was a problem hiding this comment.
The change seems good to me, I would write one sentence to the documentation how to use it this way at the end of Docker image section. Maybe even mention that the bind-mounted output dir must have the same UID as passed in.
Some users have issues with bind mounts and UID/GID mismatch between their host users and the container user that defaults to 1000. We fix it by installing unblob system-wide within the container, making it available to any user within the container. Users that want a one-to-one mapping of their host user to the container user can do so with the `-u` docker run parameter: docker run -u $UID:$GID [...] ghcr.io/onekey-sec/unblob:latest
Contributor
Author
|
@kissgyorgy done |
qkaiser
force-pushed
the
971-system-wide-install-container
branch
from
073dfad to
274c984
Compare
kissgyorgy
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users have issues with bind mounts and UID/GID mismatch between their host users and the container user that defaults to 1000.
We fix it by installing unblob system-wide within the container, making it available to any user within the container.
Users that want a one-to-one mapping of their host user to the container user can do so with the
-udocker run parameter:Resolve #971