chore: bump pyproject version to 3.2.8 + gitignore stale clones [no-ado]#128
Merged
Merged
Conversation
Two small housekeeping items: - `pyproject.toml` and `onelogin/__init__.__version__` were stuck at 3.2.6 while PyPI is now at 3.2.8 (the publish workflow extracts the version from the git tag, so this didn't block releases — but anyone running `pip install -e .` against `main` got a misleading version string). Bumped both to 3.2.8 to match the current release. - `.gitignore` now excludes `/onelogin-python-sdk/` to prevent a recurring case where a stale self-clone of the repo ends up checked out at the repo root (e.g., after a wget of a release tarball). This was harmless but caused grep noise and confused diff-against-the-repo tooling. No functional change. All 358 tests still pass.
3 tasks
Subterrane
added a commit
that referenced
this pull request
May 12, 2026
Two concrete fixes plus general tightening: 1. The Getting Started example created Configuration twice — once with the host URL, then immediately reassigned the variable with username/password (dropping the host). A user copy-pasting the example would silently hit the OneLogin default host instead of their own subdomain. Collapsed into a single Configuration() call that accepts host + credentials in one shot. 2. The Release Process section said the publish workflow "updates `version` in pyproject.toml and `__version__` in onelogin/__init__.py". That's technically true but misleading — the workflow runs `sed -i` inside the ephemeral CI runner and never commits back to main. The source tree drift this caused was exactly what PR #128 fixed manually. The section now states the truth plainly: edits happen in the runner only, the source tree may lag, reconcile periodically. Also: - Trimmed redundant "First, install the package" sections (Tests and Installation said the same thing twice). - Dropped per-dependency version pin list in Requirements — that belongs in `pyproject.toml`, not in two places. - Removed inline auto-generated-comment noise from the example (`# GenerateTokenRequest | Request Body to ...`) and the redundant explicit `content_type="application/json"` which is the default. - Added a one-line pointer to `docs/` for per-endpoint documentation. - Added `[lint]` to the dev install instructions (introduced in PR #130). - Aligned the example tag format with current convention (`3.2.9` not `v3.2.9`; only `v3.2.0` is the legacy outlier). - Added a ValidationError-on-response troubleshooting entry that points users at PR #126 / #131 as worked examples — they're the most common bug class with this SDK and a quick issue gets fixed fast. Line count: 163 → 85.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two trivial housekeeping items in one PR — no functional change.
Reconcile
pyproject.tomlversion: was stuck at3.2.6while PyPI is now3.2.8. The publish workflow extracts version from the git tag, so this didn't block releases, but anyone running `pip install -e .` against `main` got a misleading version string. Also updates `onelogin/init.version`.Gitignore stale self-clones: adds `/onelogin-python-sdk/` to `.gitignore`. A clone of the repo had appeared under the repo root (probably from extracting a release tarball at some point). It was untracked and harmless, but caused grep noise and confused diff-tooling.
Test plan